[turbofan] Make MachineType a pair of enums.

test/cctest/compiler/test-gap-resolver.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/gap-resolver.h"
 
 #include "src/base/utils/random-number-generator.h"
 #include "test/cctest/cctest.h"
 
 namespace v8 {
@@ skipping 68 matching lines @@
     LocationOperand::LocationKind kind;
     int index;
     if (!is_constant) {
       if (op.IsRegister()) {
         index = LocationOperand::cast(op).GetRegister().code();
       } else if (op.IsDoubleRegister()) {
         index = LocationOperand::cast(op).GetDoubleRegister().code();
       } else {
         index = LocationOperand::cast(op).index();
       }
-      is_float = IsFloatingPoint(LocationOperand::cast(op).machine_type());
+      is_float = IsFloatingPoint(LocationOperand::cast(op).representation());
       kind = LocationOperand::cast(op).location_kind();
     } else {
       index = ConstantOperand::cast(op).virtual_register();
       kind = LocationOperand::REGISTER;
     }
     Key key = {is_constant, is_float, kind, index};
     return key;
   }
 
   static Value ValueFor(const InstructionOperand& op) { return KeyFor(op); }
@@ skipping 71 matching lines @@
       MoveOperands mo(CreateRandomOperand(true), CreateRandomOperand(false));
       if (!mo.IsRedundant() && seen.find(mo.destination()) == seen.end()) {
         parallel_move->AddMove(mo.source(), mo.destination());
         seen.insert(mo.destination());
       }
     }
     return parallel_move;
   }
 
  private:
-  MachineType RandomType() {
+  MachineRepresentation RandomRepresentation() {
     int index = rng_->NextInt(3);
     switch (index) {
       case 0:
-        return kRepWord32;
+        return MachineRepresentation::kWord32;
       case 1:
-        return kRepWord64;
+        return MachineRepresentation::kWord64;
       case 2:
-        return kRepTagged;
+        return MachineRepresentation::kTagged;
     }
     UNREACHABLE();
-    return kMachNone;
+    return MachineRepresentation::kNone;
   }
 
-  MachineType RandomDoubleType() {
+  MachineRepresentation RandomDoubleRepresentation() {
     int index = rng_->NextInt(2);
-    if (index == 0) return kRepFloat64;
-    return kRepFloat32;
+    if (index == 0) return MachineRepresentation::kFloat64;
+    return MachineRepresentation::kFloat32;
   }
 
   InstructionOperand CreateRandomOperand(bool is_source) {
     int index = rng_->NextInt(7);
     // destination can't be Constant.
     switch (rng_->NextInt(is_source ? 7 : 6)) {
       case 0:
-        return AllocatedOperand(LocationOperand::STACK_SLOT, RandomType(),
-                                index);
+        return AllocatedOperand(LocationOperand::STACK_SLOT,
+                                RandomRepresentation(), index);
       case 1:
-        return AllocatedOperand(LocationOperand::STACK_SLOT, RandomDoubleType(),
-                                index);
+        return AllocatedOperand(LocationOperand::STACK_SLOT,
+                                RandomDoubleRepresentation(), index);
       case 2:
-        return AllocatedOperand(LocationOperand::REGISTER, RandomType(), index);
+        return AllocatedOperand(LocationOperand::REGISTER,
+                                RandomRepresentation(), index);
       case 3:
-        return AllocatedOperand(LocationOperand::REGISTER, RandomDoubleType(),
-                                index);
+        return AllocatedOperand(LocationOperand::REGISTER,
+                                RandomDoubleRepresentation(), index);
       case 4:
         return ExplicitOperand(
-            LocationOperand::REGISTER, RandomType(),
+            LocationOperand::REGISTER, RandomRepresentation(),
             RegisterConfiguration::ArchDefault(RegisterConfiguration::TURBOFAN)
                 ->GetAllocatableGeneralCode(1));
       case 5:
         return ExplicitOperand(
-            LocationOperand::STACK_SLOT, RandomType(),
+            LocationOperand::STACK_SLOT, RandomRepresentation(),
             RegisterConfiguration::ArchDefault(RegisterConfiguration::TURBOFAN)
                 ->GetAllocatableGeneralCode(index));
       case 6:
         return ConstantOperand(index);
     }
     UNREACHABLE();
     return InstructionOperand();
   }
 
  private:
@@ skipping 16 matching lines @@
       resolver.Resolve(pm);
 
       CHECK(mi1.state() == mi2.state());
     }
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8