Add CMN instruction to ARM integrated assembler.

Add CMN instruction to ARM integrated assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4c435d328c90e128543733b54e27bfca2195e54d

[Karl, 2015-12-08 22:19:31]

Description was changed from

==========
Add CMN instruction to ARM integrated assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add CMN instruction to ARM integrated assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-12-08 22:19:31]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-12-08 22:21:51]

lgtm

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
File tests_lit/assembler/arm32/cmn.ll (right):

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
tests_lit/assembler/arm32/cmn.ll:1: ; Show that we know how to translate add.
not add

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
tests_lit/assembler/arm32/cmn.ll:21: define internal i32 @_Z12icmp_zeroSgei(i32
%a) {
Nit: how about a friendlier function name?

[Karl, 2015-12-08 22:45:31]

Description was changed from

==========
Add CMN instruction to ARM integrated assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add CMN instruction to ARM integrated assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2015-12-08 22:45:32]

Committed patchset #2 (id:20001) manually as
4c435d328c90e128543733b54e27bfca2195e54d (presubmit successful).

[Karl, 2015-12-08 22:45:44]

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
File tests_lit/assembler/arm32/cmn.ll (right):

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
tests_lit/assembler/arm32/cmn.ll:1: ; Show that we know how to translate add.
On 2015/12/08 22:21:51, stichnot wrote:
> not add

My cut and paste skills are getting worse! Fixed.

https://codereview.chromium.org/1513543002/diff/1/tests_lit/assembler/arm32/c...
tests_lit/assembler/arm32/cmn.ll:21: define internal i32 @_Z12icmp_zeroSgei(i32
%a) {
On 2015/12/08 22:21:51, stichnot wrote:
> Nit: how about a friendlier function name?

Done.