Issue 15135002: Merge 199564 "[Android] Auto-generate only necessary v14 resources."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15135002: Merge 199564 "[Android] Auto-generate only necessary v14 resources." (Closed)

Created:
7 years, 7 months ago by newt (away)

Modified:
7 years, 7 months ago

Reviewers:
Kibeom Kim (inactive)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199564 "[Android] Auto-generate only necessary v14 resources." > [Android] Auto-generate only necessary v14 resources. > > V14 Resource auto-generation was introduced by crbug.com/235118. > However, some resources doesn't use v17 attributes, so we don't > need to generate for all resources. > > BUG=239742 > > Review URL: https://chromiumcodereview.appspot.com/14812015 TBR=kkimlabs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199760

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -335 lines)			Patch
D	build/android/gyp/copy_v17_resources.py	View	1 chunk	+0 lines, -98 lines	0 comments	Download
A +	build/android/gyp/generate_v14_compatible_resources.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	build/android/gyp/generate_v14_resources.py	View	1 chunk	+0 lines, -204 lines	0 comments	Download
M	build/java.gypi	View	5 chunks	+10 lines, -34 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199760.

Expand Messages | Collapse Messages