Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1513493002: Improve upper bound finalization in VM and fix #25122. (Closed)

Created:
5 years ago by regis
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve upper bound finalization in VM and fix #25122. Add regression test. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/173c1aed511f4357a43566de8b91c98f2e11f43e

Patch Set 1 #

Total comments: 1

Patch Set 2 : mark new test as failing for dart2js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/regress_25122_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
5 years ago (2015-12-08 20:54:25 UTC) #2
rmacnak
https://codereview.chromium.org/1513493002/diff/1/tests/language/regress_25122_test.dart File tests/language/regress_25122_test.dart (right): https://codereview.chromium.org/1513493002/diff/1/tests/language/regress_25122_test.dart#newcode10 tests/language/regress_25122_test.dart:10: extends AbstractListMember<String, M> {} What causes these to be ...
5 years ago (2015-12-08 22:03:33 UTC) #3
regis
On 2015/12/08 22:03:33, rmacnak wrote: > https://codereview.chromium.org/1513493002/diff/1/tests/language/regress_25122_test.dart > File tests/language/regress_25122_test.dart (right): > > https://codereview.chromium.org/1513493002/diff/1/tests/language/regress_25122_test.dart#newcode10 > ...
5 years ago (2015-12-08 22:16:43 UTC) #4
rmacnak
On 2015/12/08 22:16:43, regis wrote: > On 2015/12/08 22:03:33, rmacnak wrote: > > > https://codereview.chromium.org/1513493002/diff/1/tests/language/regress_25122_test.dart ...
5 years ago (2015-12-08 22:17:44 UTC) #5
regis
5 years ago (2015-12-08 22:38:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
173c1aed511f4357a43566de8b91c98f2e11f43e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698