Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 1513483008: MD Downloads: declare/initialize ActionService#searchTerms_ in ctor (Closed)

Created:
5 years ago by Dan Beam
Modified:
5 years ago
Reviewers:
esprehn
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-data-limits
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: declare/initialize ActionService#searchTerms_ in ctor This prevents weirdness with multiple instances of ActionService. This probably shouldn't affect a singleton class much, but doesn't hurt and also changes how the property is set up in the __proto__ chain (i.e. setting it and deleting it would affect the same property descriptor). R=esprehn@chromium.org BUG=none Committed: https://crrev.com/2870b1db6b17eeb3c772000b7810ae19f75a0ccf Cr-Commit-Position: refs/heads/master@{#364539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/md_downloads/action_service.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Dan Beam
5 years ago (2015-12-10 22:07:44 UTC) #1
esprehn
lgtm
5 years ago (2015-12-10 22:57:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483008/1
5 years ago (2015-12-10 23:10:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 00:13:27 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-11 00:14:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2870b1db6b17eeb3c772000b7810ae19f75a0ccf
Cr-Commit-Position: refs/heads/master@{#364539}

Powered by Google App Engine
This is Rietveld 408576698