Issue 1513463002: MIPS64: [turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1513463002: MIPS64: [turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64. (Closed)

Created:
5 years ago by akos.palfi.imgtec

Modified:
5 years ago

Reviewers:
ivica.bogosavljevic, balazs.kilvady, ahaas, paul.l...

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@trytrunc-uint64

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

MIPS64: [turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64. Port for https://codereview.chromium.org/1507703002/ Original commit message: This operator now provides a second output which indicates whether the conversion from float64 to uint64 was successful or not. The second output returns 0 if the conversion fails, or something else if the conversion succeeds. The second output can be ignored, which means that the operator can be used the same as the original operator. BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -13 lines)			Patch
M	src/compiler/mips64/code-generator-mips64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/mips64/instruction-selector-mips64.cc	View	1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/mips64/macro-assembler-mips64.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/mips64/macro-assembler-mips64.cc	View	4 chunks	+19 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 1507703002 Patch 40001

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

l-g-t-m

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages