src/runtime.cc - Issue 151343006: Fix %OptimizeFunctionOnNextCall wrt concurrent compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 151343006: Fix %OptimizeFunctionOnNextCall wrt concurrent compilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 333a2dc4b4346bc479b5e335e14bb1bdb3d96199..372d74b74ad81dc19e15c61b4cb837070cb9b3d4 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -8503,7 +8503,12 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_OptimizeFunctionOnNextCall) {

RUNTIME_ASSERT(args.length() == 1 || args.length() == 2);

CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);

- if (!function->IsOptimizable()) return isolate->heap()->undefined_value();

+ if (!function->IsOptimizable() &&

+ !function->IsMarkedForConcurrentOptimization() &&

+ !function->IsInOptimizationQueue()) {

+ return isolate->heap()->undefined_value();

+ }

function->MarkForOptimization();

Code* unoptimized = function->shared()->code();

« no previous file with comments | « no previous file | no next file » | no next file with comments »