Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 151343002: Web MIDI: make naming convention be consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index 109c3d7cee4a77f679c425c089563a1e6a8c086f..8292a16a6719dbbba764bcaae1d9a1866470b504 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -166,17 +166,17 @@ net::URLRequestContextGetter* AwBrowserContext::GetMediaRequestContext() {
return GetRequestContext();
}
-void AwBrowserContext::RequestMIDISysExPermission(
+void AwBrowserContext::RequestMidiSysExPermission(
int render_process_id,
int render_view_id,
int bridge_id,
const GURL& requesting_frame,
- const MIDISysExPermissionCallback& callback) {
- // TODO(toyoshim): Android is not supported yet.
+ const MidiSysExPermissionCallback& callback) {
+ // TODO(crbug.com/339767): Android is not supported yet.
boliu 2014/01/31 15:51:33 nit: This is unconventional. Why not just put the
scherkus (not reviewing) 2014/01/31 20:48:54 +1 -- keep it: TODO(username): Summary of what ne
Takashi Toyoshima 2014/02/03 04:24:53 Thanks. I update the comment to say it's WebView.
callback.Run(false);
}
-void AwBrowserContext::CancelMIDISysExPermissionRequest(
+void AwBrowserContext::CancelMidiSysExPermissionRequest(
int render_process_id,
int render_view_id,
int bridge_id,

Powered by Google App Engine
This is Rietveld 408576698