chrome/browser/download/download_target_determiner_delegate.h - Issue 1513413002: Enable "Hide Extension" option when "Save Link As" on the Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_target_determiner_delegate.h

Issue 1513413002: Enable "Hide Extension" option when "Save Link As" on the Mac Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_target_determiner.cc ('k') | chrome/browser/download/download_target_determiner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_target_determiner_delegate.h

diff --git a/chrome/browser/download/download_target_determiner_delegate.h b/chrome/browser/download/download_target_determiner_delegate.h

index f2aeec6f03625bf71cb9a3a1461f2bd68d700f88..a8875d2805a7cc0db00c4677cfe6564ff9877c1f 100644

--- a/chrome/browser/download/download_target_determiner_delegate.h

+++ b/chrome/browser/download/download_target_determiner_delegate.h

@@ -47,8 +47,8 @@ class DownloadTargetDeterminerDelegate {

// selection, then this parameter will be the empty path. On Chrome OS,

// this path may contain virtual mount points if the user chose a virtual

// path (e.g. Google Drive).

- typedef base::Callback<void(const base::FilePath& virtual_path)>

- FileSelectedCallback;

+ typedef base::Callback<void(const base::FilePath& virtual_path,

+ bool hide_file_extension)> FileSelectedCallback;

// Callback to be invoked when DetermineLocalPath() completes. The argument

// should be the determined local path. It should be non-empty on success. If