content/shell/browser/shell_download_manager_delegate.cc - Issue 1513413002: Enable "Hide Extension" option when "Save Link As" on the Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_download_manager_delegate.cc

Issue 1513413002: Enable "Hide Extension" option when "Save Link As" on the Mac Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/file_metadata_unittest_mac.mm ('K') | « content/public/browser/download_manager_delegate.h ('k') | ui/shell_dialogs/select_file_dialog_mac.mm » ('j') | ui/shell_dialogs/select_file_dialog_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_download_manager_delegate.cc

diff --git a/content/shell/browser/shell_download_manager_delegate.cc b/content/shell/browser/shell_download_manager_delegate.cc

index da4978ee419b25a575927c51f776f27cbc8e0e3b..3a68c207831d723a263a4c9875134f33ece7dc56 100644

--- a/content/shell/browser/shell_download_manager_delegate.cc

+++ b/content/shell/browser/shell_download_manager_delegate.cc

@@ -71,7 +71,8 @@ bool ShellDownloadManagerDelegate::DetermineDownloadTarget(

callback.Run(download->GetForcedFilePath(),

DownloadItem::TARGET_DISPOSITION_OVERWRITE,

DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,

- download->GetForcedFilePath());

+ download->GetForcedFilePath(),

+ false);

return true;

}

@@ -139,7 +140,8 @@ void ShellDownloadManagerDelegate::OnDownloadPathGenerated(

// Testing exit.

callback.Run(suggested_path, DownloadItem::TARGET_DISPOSITION_OVERWRITE,

DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,

- suggested_path.AddExtension(FILE_PATH_LITERAL(".crdownload")));

+ suggested_path.AddExtension(FILE_PATH_LITERAL(".crdownload")),

+ false);

return;

}

@@ -183,7 +185,7 @@ void ShellDownloadManagerDelegate::ChooseDownloadPath(

#endif

callback.Run(result, DownloadItem::TARGET_DISPOSITION_PROMPT,

- DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS, result);

+ DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS, result, false);

}

void ShellDownloadManagerDelegate::SetDownloadBehaviorForTesting(