Add a leaked reference to g_browser_process before showing the uninstall dialog to avoid the views …

chrome/browser/ui/views/uninstall_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/uninstall_view.h"
 
 #include "base/message_loop.h"
 #include "base/process_util.h"
 #include "base/run_loop.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/ui/uninstall_browser_prompt.h"
 #include "chrome/common/chrome_result_codes.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/shell_util.h"
 #include "grit/chromium_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/controls/button/checkbox.h"
 #include "ui/views/controls/combobox/combobox.h"
 #include "ui/views/controls/label.h"
@@ skipping 139 matching lines @@
   std::advance(i, index);
   return i->first;
 }
 
 namespace chrome {
 
 int ShowUninstallBrowserPrompt(bool show_delete_profile) {
   DCHECK_EQ(base::MessageLoop::TYPE_UI, base::MessageLoop::current()->type());
   int result = content::RESULT_CODE_NORMAL_EXIT;
   views::AcceleratorHandler accelerator_handler;
+
+  // Take a reference on g_browser_process while showing the dialog. This is
+  // done because the dialog uses the views framework which may increment
+  // and decrement the module ref count during the course of displaying UI and
+  // this code can be called while the module refcount is still at 0.
+  // Note that this reference is never released, as this code is shown on a path
+  // that immediately exits Chrome anyway.
+  // See http://crbug.com/241366 for details.
+  g_browser_process->AddRefModule();

[sky, 2013/05/16 19:26:50]

How does the ref count end up hitting 0 here?

+
   base::RunLoop run_loop(&accelerator_handler);
   UninstallView* view = new UninstallView(&result,
                                           run_loop.QuitClosure(),
                                           show_delete_profile);
   views::Widget::CreateWindow(view)->Show();
   run_loop.Run();
   return result;
 }
 
 }  // namespace chrome