Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: src/compiler/change-lowering.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: please mips64 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/basic-block-instrumentor.cc ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/change-lowering.cc
diff --git a/src/compiler/change-lowering.cc b/src/compiler/change-lowering.cc
index 88631f9e6810b37962cfc41eaa900277ebd7294d..a96d4d6f53ece1ee4daa43ba757042c6cc8aed12 100644
--- a/src/compiler/change-lowering.cc
+++ b/src/compiler/change-lowering.cc
@@ -87,10 +87,10 @@ Node* ChangeLowering::AllocateHeapNumberWithValue(Node* value, Node* control) {
}
Node* heap_number = graph()->NewNode(allocate_heap_number_operator_.get(),
target, context, effect, control);
- Node* store = graph()->NewNode(machine()->Store(StoreRepresentation(
- MachineType::Float64(), kNoWriteBarrier)),
- heap_number, HeapNumberValueIndexConstant(),
- value, heap_number, control);
+ Node* store = graph()->NewNode(
+ machine()->Store(StoreRepresentation(MachineRepresentation::kFloat64,
+ kNoWriteBarrier)),
+ heap_number, HeapNumberValueIndexConstant(), value, heap_number, control);
return graph()->NewNode(common()->FinishRegion(), heap_number, store);
}
@@ -485,8 +485,9 @@ Reduction ChangeLowering::StoreField(Node* node) {
type);
Node* offset = jsgraph()->IntPtrConstant(access.offset - access.tag());
node->InsertInput(graph()->zone(), 1, offset);
- NodeProperties::ChangeOp(
- node, machine()->Store(StoreRepresentation(access.machine_type, kind)));
+ NodeProperties::ChangeOp(node,
+ machine()->Store(StoreRepresentation(
+ access.machine_type.representation(), kind)));
return Changed(node);
}
@@ -529,7 +530,7 @@ Reduction ChangeLowering::StoreElement(Node* node) {
node->ReplaceInput(1, ComputeIndex(access, node->InputAt(1)));
NodeProperties::ChangeOp(
node, machine()->Store(StoreRepresentation(
- access.machine_type,
+ access.machine_type.representation(),
ComputeWriteBarrierKind(access.base_is_tagged,
access.machine_type.representation(),
access.type, type))));
« no previous file with comments | « src/compiler/basic-block-instrumentor.cc ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698