Skia version roll to a1bb8e02fe7956b2f85a0afadbca5f607a804403

Skia version roll to a1bb8e02fe7956b2f85a0afadbca5f607a804403

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f0e7a474fe9a7dff9be77da327b41c032708a071

[Sean Klein, 2015-12-12 01:36:59]

Description was changed from

==========
Skia version roll to Nov 11th (next commit causes breakage)
==========

to

==========
Skia version roll to Nov 11th (next commit causes breakage)

BUG=#594
==========

[Sean Klein, 2015-12-12 01:40:47]

Description was changed from

==========
Skia version roll to Nov 11th (next commit causes breakage)

BUG=#594
==========

to

==========
Skia version roll to Nov 11th

The following commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
causes a breakage and will need to be dealt with manually.

BUG=#594
==========

[Sean Klein, 2015-12-12 02:09:11]

Description was changed from

==========
Skia version roll to Nov 11th

The following commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
causes a breakage and will need to be dealt with manually.

BUG=#594
==========

to

==========
Skia version roll

The following commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
causes a breakage and is dealt with manually.

BUG=#594
==========

[Sean Klein, 2015-12-12 02:09:28]

Description was changed from

==========
Skia version roll

The following commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
causes a breakage and is dealt with manually.

BUG=#594
==========

to

==========
Skia version roll

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
==========

[Sean Klein, 2015-12-12 02:11:20]

Description was changed from

==========
Skia version roll

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
==========

to

==========
Skia version roll to a1bb8e02fe7956b2f85a0afadbca5f607a804403

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
==========

[Sean Klein, 2015-12-12 02:18:06]

smklein@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-12-12 02:27:20]

Some more details about "breakage" would be nice, either here or in the bug.

[Sean Klein, 2015-12-12 02:46:33]

On 2015/12/12 02:27:20, viettrungluu wrote:
> Some more details about "breakage" would be nice, either here or in the bug.

Sure.

This Skia CL: https://codereview.chromium.org/1432903002/
Changed "src/core/SkOpts.cpp" to declare "Init_avx()" but not define it.
By rolling Mojo's deps to this point, Skia would not build due to a linking
error:
   ../../third_party/skia/src/core/SkOpts.cpp:104: error: undefined reference to
'SkOpts::Init_avx()'

The Skia CL also altered gyp/opts.gypi, so "avx_sources" included a new file,
"SkOpts_avx.cpp". This file includes the necessary "Init_avx" symbol.

By adding avx_sources to the "sources" of "skia_opts", this error is removed.

[viettrungluu, 2015-12-12 03:21:18]

On 2015/12/12 02:46:33, smklein1 wrote:
> On 2015/12/12 02:27:20, viettrungluu wrote:
> > Some more details about "breakage" would be nice, either here or in the bug.
> 
> Sure.
> 
> This Skia CL: https://codereview.chromium.org/1432903002/
> Changed "src/core/SkOpts.cpp" to declare "Init_avx()" but not define it.
> By rolling Mojo's deps to this point, Skia would not build due to a linking
> error:
>    ../../third_party/skia/src/core/SkOpts.cpp:104: error: undefined reference
to
> 'SkOpts::Init_avx()'
> 
> The Skia CL also altered gyp/opts.gypi, so "avx_sources" included a new file,
> "SkOpts_avx.cpp". This file includes the necessary "Init_avx" symbol.
> 
> By adding avx_sources to the "sources" of "skia_opts", this error is removed.

Thanks. I (mistakenly) thought that the reason for the roll was to fix the
breakage, but I guess the roll is for independent reasons.

Anyhow, LGTM.

[Sean Klein, 2015-12-14 17:14:57]

Description was changed from

==========
Skia version roll to a1bb8e02fe7956b2f85a0afadbca5f607a804403

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
==========

to

==========
Skia version roll to a1bb8e02fe7956b2f85a0afadbca5f607a804403

The following Skia commit, 084db25d47dbad3ffbd7d15c04b63d344b351f90,
caused a breakage and was dealt with manually.

BUG=#594
R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/f0e7a474fe9a7dff9be77da327b...
==========

[Sean Klein, 2015-12-14 17:14:58]

Committed patchset #3 (id:40001) manually as
f0e7a474fe9a7dff9be77da327b41c032708a071 (presubmit successful).