Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1513363003: fix safari test (Closed)

Created:
5 years ago by Siggi Cherem (dart-lang)
Modified:
5 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix safari test Apparently my approach to use wss didn't work to exercise the error codepath. This change makes us excersize errors. After testing this in Safari though, I coudln't reproduce the issue, so I remove the note about this being a regression test for the original issue. Committed: https://github.com/dart-lang/sdk/commit/e6f6ce97436f667ffa5c2e3761bac78443c72977

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M tests/html/websocket_test.dart View 1 2 1 chunk +4 lines, -21 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
Siggi Cherem (dart-lang)
5 years ago (2015-12-10 23:27:08 UTC) #3
Siggi Cherem (dart-lang)
5 years ago (2015-12-11 00:02:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e6f6ce97436f667ffa5c2e3761bac78443c72977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698