Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1513353002: Fix speech flushing on Aura platforms in compat mode. (Closed)

Created:
5 years ago by David Tseng
Modified:
5 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix speech flushing on Aura platforms in compat mode. This gets ChromeVox flushing properly when reading Aura nodes. We will have to do something else to fix flushing for web content in ChromeVox Next. TEST=webstore release, tab through toolbar and verify speech flushes. Navigate using ChromeVox commands and verify flushing. Committed: https://crrev.com/60c2d13d384de1fced9bb70c75b8ca45bac3aecd Cr-Commit-Position: refs/heads/master@{#364786}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
David Tseng
5 years ago (2015-12-10 20:48:21 UTC) #3
dmazzoni
lgtm Could we also flush whenever we get a ChromeVox command?
5 years ago (2015-12-10 21:11:45 UTC) #5
David Tseng
https://codereview.chromium.org/1513353002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js (right): https://codereview.chromium.org/1513353002/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#newcode489 chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:489: .withQueueMode(cvox.QueueMode.FLUSH) Flushing's done here; when there's no current range, ...
5 years ago (2015-12-10 21:20:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513353002/1
5 years ago (2015-12-11 19:48:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 20:11:57 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-11 20:13:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60c2d13d384de1fced9bb70c75b8ca45bac3aecd
Cr-Commit-Position: refs/heads/master@{#364786}

Powered by Google App Engine
This is Rietveld 408576698