DM: fix `--config $VIA-pdf` to not crash

DM: fix `--config $VIA-pdf` to not crash

Committed: https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf

[hal.canary, 2015-12-10 19:10:48]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-12-10 19:10:49]

PTAL

[hal.canary, 2015-12-10 19:10:53]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 19:11:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513323002/1

[commit-bot: I haz the power, 2015-12-10 19:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:27:14]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-12-10 19:27:57]

https://codereview.chromium.org/1513323002/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1513323002/diff/1/dm/DMSrcSink.cpp#newcode1026
dm/DMSrcSink.cpp:1026: Name name = SkStringPrintf("%s [via matrix]",
src.name().c_str());
Some ideas:
   - thread the names from DM.cpp so we can keep them exactly in sync with the
name used to construct the Via, probably working this into the VIA macro?
   - plop a method on the Via base class to do the bulk of this logic, e.g.
draw_to_canvas(this->decorateName(src), ...) ?
   - consider mirroring the format we use to construct the Vias more closely, so
it's clearer how to reproduce, e.g. "%s-%s", src.name(), via.name(), so that
instead of
  "all_bitmap_configs [via serialization] [via matrix]"
we get
  "all_bitmap_configs-serialize-matrix"

[hal.canary, 2015-12-10 20:08:47]

https://codereview.chromium.org/1513323002/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1513323002/diff/1/dm/DMSrcSink.cpp#newcode1026
dm/DMSrcSink.cpp:1026: Name name = SkStringPrintf("%s [via matrix]",
src.name().c_str());
On 2015/12/10 at 19:27:57, mtklein wrote:
> Some ideas:
>    - thread the names from DM.cpp so we can keep them exactly in sync with the
name used to construct the Via, probably working this into the VIA macro?

done

>    - plop a method on the Via base class to do the bulk of this logic, e.g.
draw_to_canvas(this->decorateName(src), ...) ?

done

>    - consider mirroring the format we use to construct the Vias more closely,
so it's clearer how to reproduce, e.g. "%s-%s", src.name(), via.name(), so that
instead of

done

[mtklein, 2015-12-10 20:24:10]

lgtm

[hal.canary, 2015-12-10 20:26:05]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-12-10 20:26:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513323002/40001

[commit-bot: I haz the power, 2015-12-10 20:46:44]

Description was changed from

==========
DM: fix `--config $VIA-pdf` to not crash
==========

to

==========
DM: fix `--config $VIA-pdf` to not crash

Committed:
https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf
==========

[commit-bot: I haz the power, 2015-12-10 20:46:44]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf

[msarett, 2015-12-10 23:14:13]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1513053004/ by msarett@google.com.

The reason for reverting is: I believe that this is breaking master-skia in
Android..

[mtklein, 2015-12-10 23:19:59]

On 2015/12/10 at 23:14:13, msarett wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1513053004/ by msarett@google.com.
> 
> The reason for reverting is: I believe that this is breaking master-skia in
Android..

Oh right, DMSrcSinkAndroid...