Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1513293002: kFrameTreeNodeInvalidID -> kFrameTreeNodeInvalidId (Closed)

Created:
5 years ago by ncarter (slow)
Modified:
5 years ago
Reviewers:
robwu, dcheng
CC:
asanka, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kFrameTreeNodeInvalidID -> kFrameTreeNodeInvalidId Change "ID" to "Id" to conform with Chromium's coding style. As discussed at https://groups.google.com/a/chromium.org/d/msg/site-isolation-dev/NsYJyqLXPjQ/7FEPeewRAAAJ Committed: https://crrev.com/2482a2d2f7d3c78f23466b33036a9f12b7e69662 Cr-Commit-Position: refs/heads/master@{#365973}

Patch Set 1 #

Patch Set 2 : Fix RFHM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/browser/download/save_package.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ncarter (slow)
Hi Rob, please feel free to CQ if it LGTM
5 years ago (2015-12-10 17:03:11 UTC) #3
robwu
Don't forget to replace the one at line 317 in content/browser/frame_host/render_frame_host_manager.cc (method RenderFrameHostManager::ForInnerDelegate).
5 years ago (2015-12-10 17:33:14 UTC) #4
ncarter (slow)
Done. Hopefully this compiles now.
5 years ago (2015-12-17 22:04:55 UTC) #5
dcheng
lgtm
5 years ago (2015-12-17 22:52:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513293002/20001
5 years ago (2015-12-17 22:56:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/94298)
5 years ago (2015-12-18 00:15:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513293002/20001
5 years ago (2015-12-18 00:42:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 01:39:47 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-18 01:40:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2482a2d2f7d3c78f23466b33036a9f12b7e69662
Cr-Commit-Position: refs/heads/master@{#365973}

Powered by Google App Engine
This is Rietveld 408576698