Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1513283003:
Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. (Closed)
|
Created:
5 years ago by Stephen White Modified:
5 years ago CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef.
This will cause Skia to do more accurate allocations for offscreen
buffers, reducing memory usage.
Mark affected tests as needing rebaseline, or give new reference result.
BUG=240827
R=fmalita@chromium.org
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/d9ceaad90369f2840adfb88515298c816afb5c72
Cr-Commit-Position: refs/heads/master@{#365069}
Patch Set 1 #Patch Set 2 : Mark some more tests for rebaseline #Patch Set 3 : Whitespace change to try to trigger layout test runs #Patch Set 4 : A different whitespace change #Patch Set 5 : mark another test as needing rebaseline #Patch Set 6 : Revert whitespace change #Patch Set 7 : Tweak expectations #Patch Set 8 : More test tweakage #Patch Set 9 : Add new cc_unittests pixel results #Patch Set 10 : Tweak TestExpectations #
Messages
Total messages: 46 (25 generated)
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/1
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/20001
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/60001
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 ==========
senorblanco@chromium.org changed reviewers: + fmalita@chromium.org
Florin: PTAL. Thanks!
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/100001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by senorblanco@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/1513283003/#ps120001 (title: "Tweak expectations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/130001
Message was sent while issue was closed.
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://crrev.com/d42be13c51bbc3969f2b3b9f9e1c6f0abf236a3e Cr-Commit-Position: refs/heads/master@{#364495} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/d42be13c51bbc3969f2b3b9f9e1c6f0abf236a3e Cr-Commit-Position: refs/heads/master@{#364495}
Message was sent while issue was closed.
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://crrev.com/d42be13c51bbc3969f2b3b9f9e1c6f0abf236a3e Cr-Commit-Position: refs/heads/master@{#364495} ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:130001) manually as d42be13c51bbc3969f2b3b9f9e1c6f0abf236a3e (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:130001) has been created in https://codereview.chromium.org/1516073003/ by mek@chromium.org. The reason for reverting is: This is causing cc_unittests failures on the main waterfall: https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bu... and https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2... .
Message was sent while issue was closed.
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... ==========
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42be13c51bbc3969f2b3b9f9e1c... CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org TBR=danakj@chromium.org ==========
senorblanco@chromium.org changed reviewers: + danakj@chromium.org
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/150001
The CQ bit was unchecked by sergiyb@chromium.org
On 2015/12/14 16:11:13, Sergiy Byelozyorov wrote: > The CQ bit was unchecked by mailto:sergiyb@chromium.org I've unchecked CQ bit to stop this CL flooding tryservers due to an ongoing outage. And please do not re-land same CL multiple times. Create a new one instead.
On 2015/12/14 16:11:54, Sergiy Byelozyorov wrote: > On 2015/12/14 16:11:13, Sergiy Byelozyorov wrote: > > The CQ bit was unchecked by mailto:sergiyb@chromium.org > > I've unchecked CQ bit to stop this CL flooding tryservers due to an ongoing > outage. No problem, but shouldn't that be prevented at the server, instead of stopping individual jobs? Or is there something problematic with this particular CL? > And please do not re-land same CL multiple times. Create a new one instead. What's the reasoning here? As a reviewer, I find it helpful to see the diffs between the problematic CL and the updated one.
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org TBR=danakj@chromium.org ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/170001
The CQ bit was unchecked by senorblanco@chromium.org
The CQ bit was checked by senorblanco@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/1513283003/#ps170001 (title: "Tweak TestExpectations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513283003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513283003/170001
Message was sent while issue was closed.
Committed patchset #10 (id:170001)
Message was sent while issue was closed.
Description was changed from ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS #ifdef. This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d9ceaad90369f2840adfb88515298c816afb5c72 Cr-Commit-Position: refs/heads/master@{#365069} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/d9ceaad90369f2840adfb88515298c816afb5c72 Cr-Commit-Position: refs/heads/master@{#365069}
Message was sent while issue was closed.
This CL has caused cc_unittests failures on Windows bots, but I've landed https://codereview.chromium.org/1525783002/ to address those, after which the Windows bots should go green. Sheriffs: if you must revert this patch, please revert https://codereview.chromium.org/1525783002/ as well. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
