Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: pkg/compiler/lib/src/parser/partial_elements.dart

Issue 1513263002: Support optional package name arguments to --show-package-warnings (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/parser/partial_elements.dart
diff --git a/pkg/compiler/lib/src/parser/partial_elements.dart b/pkg/compiler/lib/src/parser/partial_elements.dart
index e26d83805b8607588e2780e935a9e4270b6bb9b9..d72c6b739766844947c00e838b1337753743555e 100644
--- a/pkg/compiler/lib/src/parser/partial_elements.dart
+++ b/pkg/compiler/lib/src/parser/partial_elements.dart
@@ -297,7 +297,9 @@ class PartialFieldList extends VariableList with PartialElement {
// TODO(johnniwinther): Compute this in the resolver.
VariableDefinitions node = parseNode(element, resolution.parsing);
if (node.type != null) {
- type = resolution.resolveTypeAnnotation(element, node.type);
+ type = resolution.reporter.withCurrentElement(element, () {
+ return resolution.resolveTypeAnnotation(element, node.type);
Johnni Winther 2015/12/10 14:59:04 Bug found during implementation. We could point to
Siggi Cherem (dart-lang) 2015/12/10 16:21:42 Do you think it is worth looking into https://gith
Johnni Winther 2015/12/11 10:33:28 I'll take a (new) look at 3675.
+ });
} else {
type = const DynamicType();
}

Powered by Google App Engine
This is Rietveld 408576698