Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1513203002: Revert of Implement Fast Accessor Builder (Closed)

Created:
5 years ago by vogelheim
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement Fast Accessor Builder (patchset #14 id:260001 of https://codereview.chromium.org/1474543004/ ) Reason for revert: Broke the build, apparently. Original issue's description: > Implement FastAccessorBuilder. > > ... using the RawMachineAssembler and the work in cl/1407313004 > > BUG=chromium:508898 > LOG=Y > > Committed: https://crrev.com/515d9ccd8e6df7bf2ca01e2a55aaad30226399e1 > Cr-Commit-Position: refs/heads/master@{#32742} TBR=epertoso@chromium.org,bmeurer@chromium.org,jochen@chromium.org,mstarzinger@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:508898 Committed: https://crrev.com/0a50af8625f8c71ec2f07b22c9d5305336a2368a Cr-Commit-Position: refs/heads/master@{#32744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -853 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M include/v8.h View 3 chunks +4 lines, -9 lines 0 comments Download
D include/v8-experimental.h View 1 chunk +0 lines, -53 lines 0 comments Download
M src/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M src/api.cc View 6 chunks +13 lines, -16 lines 0 comments Download
D src/api-experimental.h View 1 chunk +0 lines, -28 lines 0 comments Download
D src/api-experimental.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D src/compiler/fast-accessor-assembler.h View 1 chunk +0 lines, -106 lines 0 comments Download
D src/compiler/fast-accessor-assembler.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +0 lines, -274 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vogelheim
Created Revert of Implement Fast Accessor Builder
5 years ago (2015-12-10 10:15:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513203002/1
5 years ago (2015-12-10 10:16:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 10:16:16 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 10:16:44 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a50af8625f8c71ec2f07b22c9d5305336a2368a
Cr-Commit-Position: refs/heads/master@{#32744}

Powered by Google App Engine
This is Rietveld 408576698