Issue 1513183004: use rounding in scaledown by 2

Issue 1513183004: use rounding in scaledown by 2 (Closed)

Created:
5 years ago by fbarchard1

Modified:
5 years ago

Reviewers:
harryjin, Diony Rosa

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

use rounding in scaledown by 2 When scaling down by 2 the formula should round consistently. (a+b+c+d+2)/4 The C version did but the SSE2 version was doing 2 averages. avg(avg(a,b),avg(c,d)) This change uses a sum, then rounds. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:447, libyuv:527 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/ae55e418517651548638b27be31d1b2abaed22bb

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -104 lines)			Patch
M	README.chromium	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/scale_row.h	View	3	3 chunks	+12 lines, -12 lines	0 comments	Download
M	include/libyuv/version.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	source/planar_functions.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	source/scale.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	source/scale_any.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	source/scale_gcc.cc	View		4 chunks	+31 lines, -31 lines	0 comments	Download
M	source/scale_win.cc	View		7 chunks	+43 lines, -41 lines	0 comments	Download
M	unit_test/planar_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

fbarchard1

5 years ago (2015-12-15 01:25:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
ae55e418517651548638b27be31d1b2abaed22bb (presubmit successful).