Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: test/mjsunit/regress/regress-325676.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/regress-3225.js ('k') | test/mjsunit/regress/regress-crbug-323936.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-325676.js
diff --git a/test/mjsunit/regress/regress-325676.js b/test/mjsunit/regress/regress-325676.js
index 427bbc38dcb3d909b3bfb1dc3a6008cec63cf9ab..7aae0cdaab1920857f44dbeaa9b32927d82976e2 100644
--- a/test/mjsunit/regress/regress-325676.js
+++ b/test/mjsunit/regress/regress-325676.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --expose-debug-as debug
+// Flags: --expose-debug-as debug --debug-eval-readonly-locals
// If a function parameter is forced to be context allocated,
// debug evaluate need to resolve it to a context slot instead of
@@ -40,7 +40,7 @@ function listener(event, exec_state, event_data, data) {
if (event != Debug.DebugEvent.Break) return;
try {
assertEquals(expected, exec_state.frame(0).evaluate('arg').value());
- exec_state.frame(0).evaluate('arg = "evaluated";');
+ exec_state.frame(0).evaluate('arg = "evaluated";'); // no effect
} catch (e) {
exception = e;
}
@@ -51,12 +51,12 @@ Debug.setListener(listener);
function f(arg) {
expected = arg;
debugger;
- assertEquals("evaluated", arg);
+ assertEquals(expected, arg);
arg = "value";
expected = arg;
debugger;
- assertEquals("evaluated", arg);
+ assertEquals(expected, arg);
// Forces arg to be context allocated even though a parameter.
function g() { arg; }
« no previous file with comments | « test/mjsunit/regress-3225.js ('k') | test/mjsunit/regress/regress-crbug-323936.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698