Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: test/mjsunit/es6/debug-blockscopes.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-shadowed-context.js ('k') | test/mjsunit/regress-3225.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/debug-blockscopes.js
diff --git a/test/mjsunit/es6/debug-blockscopes.js b/test/mjsunit/es6/debug-blockscopes.js
index 3f890ebd546d2edba74066f0fd5e5c031ce91ec6..d3c36207f1dc27bdef41e6ed963743448a63f641 100644
--- a/test/mjsunit/es6/debug-blockscopes.js
+++ b/test/mjsunit/es6/debug-blockscopes.js
@@ -26,6 +26,7 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --expose-debug-as debug --allow-natives-syntax
+// Flags: --debug-eval-readonly-locals
// The functions used for testing backtraces. They are at the top to make the
// testing of source line/column easier.
@@ -525,15 +526,12 @@ function shadowing_1() {
{
let i = 5;
debugger;
- assertEqualsUnlessOptimized(27, i, shadowing_1);
}
assertEquals(0, i);
- debugger;
- assertEqualsUnlessOptimized(27, i, shadowing_1);
}
listener_delegate = function (exec_state) {
- exec_state.frame(0).evaluate("i = 27");
+ assertEqualsUnlessOptimized(5, exec_state.frame(0).evaluate("i").value());
}
shadowing_1();
EndTest();
@@ -546,13 +544,12 @@ function shadowing_2() {
{
let j = 5;
debugger;
- assertEqualsUnlessOptimized(27, j, shadowing_2);
}
- assertEqualsUnlessOptimized(0, i, shadowing_2);
}
listener_delegate = function (exec_state) {
- exec_state.frame(0).evaluate("j = 27");
+ assertEqualsUnlessOptimized(0, exec_state.frame(0).evaluate("i").value());
+ assertEqualsUnlessOptimized(5, exec_state.frame(0).evaluate("j").value());
}
shadowing_2();
EndTest();
« no previous file with comments | « test/mjsunit/debug-evaluate-shadowed-context.js ('k') | test/mjsunit/regress-3225.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698