Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: test/mjsunit/debug-evaluate-const.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-closure.js ('k') | test/mjsunit/debug-evaluate-locals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/debug-evaluate-const.js
diff --git a/test/mjsunit/debug-evaluate-const.js b/test/mjsunit/debug-evaluate-const.js
index 7fad483cd5ebc457fb64286aa45d88e8b8c4974a..08e2f1369b0fab52200ec508de7463a719405a84 100644
--- a/test/mjsunit/debug-evaluate-const.js
+++ b/test/mjsunit/debug-evaluate-const.js
@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --expose-debug-as debug
+// Flags: --expose-debug-as debug --debug-eval-readonly-locals
Debug = debug.Debug
@@ -50,10 +50,8 @@ function f() {
debugger; // Break point.
- assertEquals(30, var0);
- // TODO(yangguo): debug evaluate should not be able to alter
- // stack-allocated const values
- // assertEquals(0, const0);
+ assertEquals(undefined, var0);
+ assertEquals(0, const0);
assertEquals(undefined, const1);
assertEquals(undefined, const2);
var var0 = 20;
@@ -66,7 +64,7 @@ function f() {
g();
- assertEquals(31, var1);
+ assertEquals(21, var1);
assertEquals(3, const3);
}
« no previous file with comments | « test/mjsunit/debug-evaluate-closure.js ('k') | test/mjsunit/debug-evaluate-locals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698