src/debug/debug-evaluate.h - Issue 1513183003: [debugger] debug-evaluate should not not modify local values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.h

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-evaluate.h

diff --git a/src/debug/debug-evaluate.h b/src/debug/debug-evaluate.h

index 178e2378817a37e0f1cc6e724d32797e24714dfc..15e4030e8db6fbb93dc7ab2a3f3794259e78e1cd 100644

--- a/src/debug/debug-evaluate.h

+++ b/src/debug/debug-evaluate.h

@@ -87,7 +87,7 @@ class DebugEvaluate : public AllStatic {

bool this_is_non_local);

MaybeHandle<Object> LoadFromContext(Handle<Context> context,

- Handle<String> name);

+ Handle<String> name, bool* global);

void StoreToContext(Handle<Context> context, Handle<String> name,

Handle<Object> value);

« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | src/flag-definitions.h » ('J')