Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: test/mjsunit/regress/regress-crbug-323936.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/regress/regress-325676.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
6 6
7 Debug = debug.Debug; 7 Debug = debug.Debug;
8 8
9 var step = 0; 9 var step = 0;
10 var exception = null; 10 var exception = null;
11 11
12 function listener(event, exec_state, event_data, data) { 12 function listener(event, exec_state, event_data, data) {
13 if (event != Debug.DebugEvent.Break) return; 13 if (event != Debug.DebugEvent.Break) return;
14 try { 14 try {
15 if (step == 0) { 15 if (step == 0) {
16 assertEquals("error", exec_state.frame(0).evaluate("e").value()); 16 assertEquals("error", exec_state.frame(0).evaluate("e").value());
17 exec_state.frame(0).evaluate("e = 'foo'"); 17 exec_state.frame(0).evaluate("write_0('foo')");
18 exec_state.frame(0).evaluate("x = 'modified'"); 18 exec_state.frame(0).evaluate("write_1('modified')");
19 } else { 19 } else {
20 assertEquals("argument", exec_state.frame(0).evaluate("e").value()); 20 assertEquals("foo", exec_state.frame(0).evaluate("e").value());
21 exec_state.frame(0).evaluate("e = 'bar'"); 21 exec_state.frame(0).evaluate("write_2('bar')");
22 } 22 }
23 step++; 23 step++;
24 } catch (e) { 24 } catch (e) {
25 print(e + e.stack); 25 print(e + e.stack);
26 exception = e; 26 exception = e;
27 } 27 }
28 } 28 }
29 29
30 Debug.setListener(listener); 30 Debug.setListener(listener);
31 31
32 function f(e, x) { 32 function f(e, x) {
33 try { 33 try {
34 throw "error"; 34 throw "error";
35 } catch(e) { 35 } catch(e) {
36 // 'e' and 'x' bind to the argument due to hoisting
37 function write_0(v) { e = v }
38 function write_1(v) { x = v }
36 debugger; 39 debugger;
37 assertEquals("foo", e); 40 assertEquals("error", e);
38 } 41 }
42 function write_2(v) { e = v }
39 debugger; 43 debugger;
40 assertEquals("bar", e); 44 assertEquals("bar", e);
41 assertEquals("modified", x); 45 assertEquals("modified", x);
42 } 46 }
43 47
44 f("argument") 48 f("argument")
45 assertNull(exception); 49 assertNull(exception);
46 assertEquals(2, step); 50 assertEquals(2, step);
OLDNEW
« no previous file with comments | « test/mjsunit/regress/regress-325676.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698