Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: test/mjsunit/regress/regress-325676.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/regress-3225.js ('k') | test/mjsunit/regress/regress-crbug-323936.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug 28 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
29 29
30 // If a function parameter is forced to be context allocated, 30 // If a function parameter is forced to be context allocated,
31 // debug evaluate need to resolve it to a context slot instead of 31 // debug evaluate need to resolve it to a context slot instead of
32 // parameter slot on the stack. 32 // parameter slot on the stack.
33 33
34 var Debug = debug.Debug; 34 var Debug = debug.Debug;
35 35
36 var expected; 36 var expected;
37 var exception = null; 37 var exception = null;
38 38
39 function listener(event, exec_state, event_data, data) { 39 function listener(event, exec_state, event_data, data) {
40 if (event != Debug.DebugEvent.Break) return; 40 if (event != Debug.DebugEvent.Break) return;
41 try { 41 try {
42 assertEquals(expected, exec_state.frame(0).evaluate('arg').value()); 42 assertEquals(expected, exec_state.frame(0).evaluate('arg').value());
43 exec_state.frame(0).evaluate('arg = "evaluated";'); 43 exec_state.frame(0).evaluate('arg = "evaluated";'); // no effect
44 } catch (e) { 44 } catch (e) {
45 exception = e; 45 exception = e;
46 } 46 }
47 } 47 }
48 48
49 Debug.setListener(listener); 49 Debug.setListener(listener);
50 50
51 function f(arg) { 51 function f(arg) {
52 expected = arg; 52 expected = arg;
53 debugger; 53 debugger;
54 assertEquals("evaluated", arg); 54 assertEquals(expected, arg);
55 55
56 arg = "value"; 56 arg = "value";
57 expected = arg; 57 expected = arg;
58 debugger; 58 debugger;
59 assertEquals("evaluated", arg); 59 assertEquals(expected, arg);
60 60
61 // Forces arg to be context allocated even though a parameter. 61 // Forces arg to be context allocated even though a parameter.
62 function g() { arg; } 62 function g() { arg; }
63 } 63 }
64 64
65 f(); 65 f();
66 f(1); 66 f(1);
67 f(1, 2); 67 f(1, 2);
68 68
69 assertNull(exception); 69 assertNull(exception);
OLDNEW
« no previous file with comments | « test/mjsunit/regress-3225.js ('k') | test/mjsunit/regress/regress-crbug-323936.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698