Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: test/mjsunit/regress-3225.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/es6/debug-blockscopes.js ('k') | test/mjsunit/regress/regress-325676.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
6 6
7 Debug = debug.Debug 7 Debug = debug.Debug
8 8
9 var debug_step = 0; 9 var debug_step = 0;
10 var failure = null; 10 var failure = null;
11 11
12 function listener(event, exec_state, event_data, data) { 12 function listener(event, exec_state, event_data, data) {
13 if (event != Debug.DebugEvent.Break) return; 13 if (event != Debug.DebugEvent.Break) return;
14 try { 14 try {
15 if (debug_step == 0) { 15 if (debug_step == 0) {
16 assertEquals(1, exec_state.frame(0).evaluate('a').value()); 16 assertEquals(1, exec_state.frame(0).evaluate('a').value());
17 assertEquals(3, exec_state.frame(0).evaluate('b').value()); 17 assertEquals(3, exec_state.frame(0).evaluate('b').value());
18 exec_state.frame(0).evaluate("a = 4").value(); 18 exec_state.frame(0).evaluate("a = 4").value(); // no effect.
19 debug_step++; 19 debug_step++;
20 } else { 20 } else {
21 assertEquals(4, exec_state.frame(0).evaluate('a').value()); 21 assertEquals(1, exec_state.frame(0).evaluate('a').value());
22 assertEquals(3, exec_state.frame(0).evaluate('b').value()); 22 assertEquals(3, exec_state.frame(0).evaluate('b').value());
23 exec_state.frame(0).evaluate("b = 5").value(); 23 exec_state.frame(0).evaluate("set_a_to_5()");
24 exec_state.frame(0).evaluate("b = 5").value(); // no effect.
24 } 25 }
25 } catch (e) { 26 } catch (e) {
26 failure = e; 27 failure = e;
27 } 28 }
28 } 29 }
29 30
30 Debug.setListener(listener); 31 Debug.setListener(listener);
31 32
32 function* generator(a, b) { 33 function* generator(a, b) {
34 function set_a_to_5() { a = 5 }
33 var b = 3; // Shadows a parameter. 35 var b = 3; // Shadows a parameter.
34 debugger; 36 debugger;
35 yield a; 37 yield a;
36 yield b; 38 yield b;
37 debugger; 39 debugger;
40 yield a;
38 return b; 41 return b;
39 } 42 }
40 43
41 var foo = generator(1, 2); 44 var foo = generator(1, 2);
42 45
43 assertEquals(4, foo.next().value); 46 assertEquals(1, foo.next().value);
44 assertEquals(3, foo.next().value); 47 assertEquals(3, foo.next().value);
45 assertEquals(5, foo.next().value); 48 assertEquals(5, foo.next().value);
49 assertEquals(3, foo.next().value);
46 assertNull(failure); 50 assertNull(failure);
47 51
48 Debug.setListener(null); 52 Debug.setListener(null);
OLDNEW
« no previous file with comments | « test/mjsunit/es6/debug-blockscopes.js ('k') | test/mjsunit/regress/regress-325676.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698