Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: test/mjsunit/debug-evaluate-modify-catch-block-scope.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
6 6
7 Debug = debug.Debug 7 Debug = debug.Debug
8 8
9 var exception = null; 9 var exception = null;
10 function listener(event, exec_state, event_data, data) { 10 function listener(event, exec_state, event_data, data) {
11 if (event != Debug.DebugEvent.Break) return; 11 if (event != Debug.DebugEvent.Break) return;
12 try { 12 try {
13 exec_state.frame(0).evaluate("bar()"); 13 exec_state.frame(0).evaluate("bar()");
14 } catch (e) { 14 } catch (e) {
15 exception = e; 15 exception = e;
16 print(e + e.stack); 16 print(e + e.stack);
17 } 17 }
18 } 18 }
19 19
20 Debug.setListener(listener); 20 Debug.setListener(listener);
21 21
22 (function() { 22 (function() {
23 "use strict"; 23 "use strict";
24 try { 24 try {
25 throw 1; 25 throw 1;
26 } catch (e) { 26 } catch (e) {
27 let a = 1; 27 let a = 1;
28 function bar() { 28 function bar() {
29 a = 2; // this has no effect, when called from debug-eval 29 a = 2;
30 e = 2; // this has no effect, when called from debug-eval. 30 e = 2;
31 } 31 }
32 debugger; 32 debugger;
33 assertEquals(1, a); 33 assertEquals(2, a);
34 assertEquals(1, e); 34 assertEquals(2, e);
35 } 35 }
36 })(); 36 })();
37 37
38 Debug.setListener(null); 38 Debug.setListener(null);
39 assertNull(exception); 39 assertNull(exception);
OLDNEW
« no previous file with comments | « test/mjsunit/debug-evaluate-locals-capturing.js ('k') | test/mjsunit/debug-evaluate-shadowed-context.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698