Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: test/mjsunit/debug-evaluate-locals.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-const.js ('k') | test/mjsunit/debug-evaluate-locals-capturing.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug 28 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
29 // Get the Debug object exposed from the debug context global object. 29 // Get the Debug object exposed from the debug context global object.
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 listenerComplete = false; 32 listenerComplete = false;
33 exception = false; 33 exception = false;
34 34
35 35
36 function h() { 36 function h() {
37 var a = 1; 37 var a = 1;
38 var b = 2; 38 var b = 2;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 assertEquals(5, exec_state.frame(0).evaluate('eval').value()); 120 assertEquals(5, exec_state.frame(0).evaluate('eval').value());
121 assertEquals(3, exec_state.frame(1).evaluate('a').value()); 121 assertEquals(3, exec_state.frame(1).evaluate('a').value());
122 // Reference error because g does not reference b. 122 // Reference error because g does not reference b.
123 assertThrows(() => exec_state.frame(1).evaluate('b'), ReferenceError); 123 assertThrows(() => exec_state.frame(1).evaluate('b'), ReferenceError);
124 assertEquals("function", 124 assertEquals("function",
125 typeof exec_state.frame(1).evaluate('eval').value()); 125 typeof exec_state.frame(1).evaluate('eval').value());
126 assertEquals(5, exec_state.frame(2).evaluate('a').value()); 126 assertEquals(5, exec_state.frame(2).evaluate('a').value());
127 assertEquals(6, exec_state.frame(2).evaluate('b').value()); 127 assertEquals(6, exec_state.frame(2).evaluate('b').value());
128 assertEquals("function", 128 assertEquals("function",
129 typeof exec_state.frame(2).evaluate('eval').value()); 129 typeof exec_state.frame(2).evaluate('eval').value());
130 // Assignments to local variables only have temporary effect.
130 assertEquals("foo", 131 assertEquals("foo",
131 exec_state.frame(0).evaluate('a = "foo"').value()); 132 exec_state.frame(0).evaluate('a = "foo"').value());
132 assertEquals("bar", 133 assertEquals("bar",
133 exec_state.frame(1).evaluate('a = "bar"').value()); 134 exec_state.frame(1).evaluate('a = "bar"').value());
134 // Indicate that all was processed. 135 // Indicate that all was processed.
135 listenerComplete = true; 136 listenerComplete = true;
136 } 137 }
137 } catch (e) { 138 } catch (e) {
138 exception = e; 139 exception = e;
139 print("Caught something. " + e + " " + e.stack); 140 print("Caught something. " + e + " " + e.stack);
140 }; 141 };
141 }; 142 };
142 143
143 // Add the debug event listener. 144 // Add the debug event listener.
144 Debug.setListener(listener); 145 Debug.setListener(listener);
145 146
146 var f_result = f(); 147 var f_result = f();
147 148
148 assertEquals('foobar', f_result); 149 assertEquals(4, f_result);
149 150
150 // Make sure that the debug event listener was invoked. 151 // Make sure that the debug event listener was invoked.
151 assertFalse(exception, "exception in listener") 152 assertFalse(exception, "exception in listener")
152 assertTrue(listenerComplete); 153 assertTrue(listenerComplete);
OLDNEW
« no previous file with comments | « test/mjsunit/debug-evaluate-const.js ('k') | test/mjsunit/debug-evaluate-locals-capturing.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698