Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: test/mjsunit/debug-evaluate-const.js

Issue 1513183003: [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis
Patch Set: addressed comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/debug-evaluate-closure.js ('k') | test/mjsunit/debug-evaluate-locals.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug 28 // Flags: --expose-debug-as debug --debug-eval-readonly-locals
29 29
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 listenerComplete = false; 32 listenerComplete = false;
33 exception = false; 33 exception = false;
34 34
35 // var0: init after break point, changed by debug eval. 35 // var0: init after break point, changed by debug eval.
36 // const0: init before break point, changed by debug eval. 36 // const0: init before break point, changed by debug eval.
37 // const1: init after break point, materialized but untouched by debug eval. 37 // const1: init after break point, materialized but untouched by debug eval.
38 // const2: init after break point, materialized and changed by debug eval. 38 // const2: init after break point, materialized and changed by debug eval.
39 // const3: context allocated const, init before break point, changed by eval. 39 // const3: context allocated const, init before break point, changed by eval.
40 function f() { 40 function f() {
41 var var1 = 21; 41 var var1 = 21;
42 const const3 = 3; 42 const const3 = 3;
43 43
44 function g() { 44 function g() {
45 const const0 = 0; 45 const const0 = 0;
46 assertEquals(undefined, const1); 46 assertEquals(undefined, const1);
47 assertEquals(undefined, const2); 47 assertEquals(undefined, const2);
48 assertEquals(3, const3); 48 assertEquals(3, const3);
49 assertEquals(21, var1); 49 assertEquals(21, var1);
50 50
51 debugger; // Break point. 51 debugger; // Break point.
52 52
53 assertEquals(30, var0); 53 assertEquals(undefined, var0);
54 // TODO(yangguo): debug evaluate should not be able to alter 54 assertEquals(0, const0);
55 // stack-allocated const values
56 // assertEquals(0, const0);
57 assertEquals(undefined, const1); 55 assertEquals(undefined, const1);
58 assertEquals(undefined, const2); 56 assertEquals(undefined, const2);
59 var var0 = 20; 57 var var0 = 20;
60 const const1 = 1; 58 const const1 = 1;
61 const const2 = 2; 59 const const2 = 2;
62 assertEquals(20, var0); 60 assertEquals(20, var0);
63 assertEquals(1, const1); 61 assertEquals(1, const1);
64 assertEquals(2, const2); 62 assertEquals(2, const2);
65 } 63 }
66 64
67 g(); 65 g();
68 66
69 assertEquals(31, var1); 67 assertEquals(21, var1);
70 assertEquals(3, const3); 68 assertEquals(3, const3);
71 } 69 }
72 70
73 71
74 function listener(event, exec_state, event_data, data) { 72 function listener(event, exec_state, event_data, data) {
75 if (event != Debug.DebugEvent.Break) return; 73 if (event != Debug.DebugEvent.Break) return;
76 try { 74 try {
77 var frame = exec_state.frame(0); 75 var frame = exec_state.frame(0);
78 var evaluate = function(something) { 76 var evaluate = function(something) {
79 return frame.evaluate(something).value() 77 return frame.evaluate(something).value()
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 try { f(); } catch (e) { } 109 try { f(); } catch (e) { }
112 110
113 Debug.setListener(listener); 111 Debug.setListener(listener);
114 112
115 f(); 113 f();
116 114
117 Debug.setListener(null); 115 Debug.setListener(null);
118 116
119 assertFalse(exception, "exception in listener") 117 assertFalse(exception, "exception in listener")
120 assertTrue(listenerComplete); 118 assertTrue(listenerComplete);
OLDNEW
« no previous file with comments | « test/mjsunit/debug-evaluate-closure.js ('k') | test/mjsunit/debug-evaluate-locals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698