fix #25171, clear "hasBeenInferred" flag when re-running resolution

fix #25171, clear "hasBeenInferred" flag when re-running resolution

TypeResolverVisitor undoes the work of InstanceMemberInferrer, so it should also unset the flag.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/b2d7ebe56ca0b99bf1c7043240d496d64181b5bf

[Jennifer Messerly, 2015-12-10 23:45:25]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Leaf, 2015-12-11 00:09:25]

lgtm.  I'm still nervous about whether we're integrating with incremental
resolution correctly, but this seems like a step in the right direction.

https://codereview.chromium.org/1513143004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1513143004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:11748: // Clear this flag, as we
just invalidated any inferred member types.
We've also invalidated anything that extends/implements/mixes this class. 
Presumably that is captured by the task model - if we're re-resolving a unit,
then we will be re-resolving everything in it's library cycle, and everything
that depends on it?

[Jennifer Messerly, 2015-12-11 00:15:51]

thanks Leaf

https://codereview.chromium.org/1513143004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1513143004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:11748: // Clear this flag, as we
just invalidated any inferred member types.
On 2015/12/11 00:09:25, Leaf wrote:
> We've also invalidated anything that extends/implements/mixes this class. 
> Presumably that is captured by the task model - if we're re-resolving a unit,
> then we will be re-resolving everything in it's library cycle, and everything
> that depends on it?

The invariant here is we'll clear the flag at basically the same time we visit
and clear the methods. So the order is:

superclass update method & superclass clear flag
...
class update method & class clear flag


In other words, because we are only operating on one class at a time in this
visitor, we shouldn't need to worry about other classes/libraries/task
model/whatever. 

If I understand the code correctly. :)

[Jennifer Messerly, 2015-12-11 00:16:55]

Description was changed from

==========
fix #25171, clear "hasBeenInferred" flag when re-running resolution

TypeResolverVisitor undoes the work of InstanceMemberInferrer, so it should also
unset the flag.
==========

to

==========
fix #25171, clear "hasBeenInferred" flag when re-running resolution

TypeResolverVisitor undoes the work of InstanceMemberInferrer, so it should also
unset the flag.

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b2d7ebe56ca0b99bf1c7043240d496d64181b5bf
==========

[Jennifer Messerly, 2015-12-11 00:16:56]

Committed patchset #1 (id:1) manually as
b2d7ebe56ca0b99bf1c7043240d496d64181b5bf (presubmit successful).