Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1513103002: Merge to XFA: Get rid of most uses of CFX_PtrArray. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Get rid of most uses of CFX_PtrArray. Original Review URL: https://codereview.chromium.org/1518593002 . (cherry picked from commit 035359cd8ddb555fa33b6133db4fd405e4660712) R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bd573f126f93acc2034be2df1c6f571670f76c35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -194 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 2 chunks +0 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 3 chunks +9 lines, -17 lines 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 6 chunks +17 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 19 chunks +29 lines, -30 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 7 chunks +15 lines, -26 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 2 chunks +15 lines, -21 lines 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 2 chunks +0 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 19 chunks +29 lines, -34 lines 0 comments Download
M core/src/fpdftext/txtproc.h View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fxcrt/extension.h View 8 chunks +8 lines, -10 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, automatic merge (!!!)
5 years ago (2015-12-10 00:32:31 UTC) #1
Lei Zhang
lgtm
5 years ago (2015-12-10 00:38:16 UTC) #2
Tom Sepez
5 years ago (2015-12-10 00:39:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bd573f126f93acc2034be2df1c6f571670f76c35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698