Issue 15131002: Merge 199540 "Fixes couple of bugs triggered on chromeos when re..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15131002: Merge 199540 "Fixes couple of bugs triggered on chromeos when re..." (Closed)

Created:
7 years, 7 months ago by sky

Modified:
7 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, marja+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 199540 "Fixes couple of bugs triggered on chromeos when re..." > Fixes couple of bugs triggered on chromeos when restoring a tab: > . Makes TabRestoreService go to loaded if asked to restore previous > session and it already has the max number of tabs. > . Adds method to TabRestoreServiceObserver this is sent when loaded. > . Makes ChromeShellDelegate use a TabRestoreServiceObserver to wait > for load to complete then restores. > > BUG=239194 > TEST=add some test coverage > R=jamescook@chromium.org, marja@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14620014 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199729

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -14 lines)			Patch
M	chrome/browser/sessions/persistent_tab_restore_service.cc	View	3 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc	View	4 chunks	+54 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_helper.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_helper.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_observer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View	3 chunks	+66 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r199729.