Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1513053004: Revert of DM: fix `--config $VIA-pdf` to not crash (Closed)

Created:
5 years ago by msarett
Modified:
5 years ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of DM: fix `--config $VIA-pdf` to not crash (patchset #3 id:40001 of https://codereview.chromium.org/1513323002/ ) Reason for revert: I believe that this is breaking master-skia in Android. Original issue's description: > DM: fix `--config $VIA-pdf` to not crash > > Committed: https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf TBR=mtklein@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/62d3b101106602d87cad91b0ac97c10003ca33a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -43 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.h View 5 chunks +10 lines, -14 lines 0 comments Download
M dm/DMSrcSink.cpp View 11 chunks +18 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of DM: fix `--config $VIA-pdf` to not crash
5 years ago (2015-12-10 23:14:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513053004/1
5 years ago (2015-12-10 23:14:21 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-10 23:14:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62d3b101106602d87cad91b0ac97c10003ca33a5

Powered by Google App Engine
This is Rietveld 408576698