Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: chrome/browser/ui/views/frame/contents_web_view.cc

Issue 1513053002: WIP - Gutterless resize on Windows Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/contents_web_view.cc
diff --git a/chrome/browser/ui/views/frame/contents_web_view.cc b/chrome/browser/ui/views/frame/contents_web_view.cc
index f77f34515dd190739e49d64309bea88f202821c0..270a012b27a208fd7e1db9f4abb13d55885f0220 100644
--- a/chrome/browser/ui/views/frame/contents_web_view.cc
+++ b/chrome/browser/ui/views/frame/contents_web_view.cc
@@ -56,6 +56,9 @@ void ContentsWebView::OnThemeChanged() {
// color. This is the color filled within the WebView's bounds when its child
// view is sized specially for fullscreen tab capture. See WebView header
// file comments for more details.
+ // TODO(ericrk): This color causes ugly guttering when the window is resized,
+ // investigate changing color to match window color. May need to special case
+ // tab capture to not break the behavior described above. crbug.com/568317
const int kBackgroundBrightness = 0x33; // 20%
const SkColor ntp_background =
theme->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND);

Powered by Google App Engine
This is Rietveld 408576698