clang/win: Let remaining chromium_code targets build with -Wextra.

components/policy/core/common/registry_dict_win_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/registry_dict_win.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "components/policy/core/common/schema.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 namespace {
 
 TEST(RegistryDictTest, SetAndGetValue) {
   RegistryDict test_dict;
 
   base::FundamentalValue int_value(42);
   base::StringValue string_value("fortytwo");
 
   test_dict.SetValue("one", scoped_ptr<base::Value>(int_value.DeepCopy()));
-  EXPECT_EQ(1, test_dict.values().size());
+  EXPECT_EQ(1u, test_dict.values().size());
   EXPECT_TRUE(base::Value::Equals(&int_value, test_dict.GetValue("one")));
   EXPECT_FALSE(test_dict.GetValue("two"));
 
   test_dict.SetValue("two", scoped_ptr<base::Value>(string_value.DeepCopy()));
-  EXPECT_EQ(2, test_dict.values().size());
+  EXPECT_EQ(2u, test_dict.values().size());
   EXPECT_TRUE(base::Value::Equals(&int_value, test_dict.GetValue("one")));
   EXPECT_TRUE(base::Value::Equals(&string_value, test_dict.GetValue("two")));
 
   scoped_ptr<base::Value> one(test_dict.RemoveValue("one"));
-  EXPECT_EQ(1, test_dict.values().size());
+  EXPECT_EQ(1u, test_dict.values().size());
   EXPECT_TRUE(base::Value::Equals(&int_value, one.get()));
   EXPECT_FALSE(test_dict.GetValue("one"));
   EXPECT_TRUE(base::Value::Equals(&string_value, test_dict.GetValue("two")));
 
   test_dict.ClearValues();
   EXPECT_FALSE(test_dict.GetValue("one"));
   EXPECT_FALSE(test_dict.GetValue("two"));
   EXPECT_TRUE(test_dict.values().empty());
 }
 
 TEST(RegistryDictTest, CaseInsensitiveButPreservingValueNames) {
   RegistryDict test_dict;
 
   base::FundamentalValue int_value(42);
   base::StringValue string_value("fortytwo");
 
   test_dict.SetValue("One", scoped_ptr<base::Value>(int_value.DeepCopy()));
-  EXPECT_EQ(1, test_dict.values().size());
+  EXPECT_EQ(1u, test_dict.values().size());
   EXPECT_TRUE(base::Value::Equals(&int_value, test_dict.GetValue("oNe")));
 
   RegistryDict::ValueMap::const_iterator entry = test_dict.values().begin();
   ASSERT_NE(entry, test_dict.values().end());
   EXPECT_EQ("One", entry->first);
 
   test_dict.SetValue("ONE", scoped_ptr<base::Value>(string_value.DeepCopy()));
-  EXPECT_EQ(1, test_dict.values().size());
+  EXPECT_EQ(1u, test_dict.values().size());
   EXPECT_TRUE(base::Value::Equals(&string_value, test_dict.GetValue("one")));
 
   scoped_ptr<base::Value> removed_value(test_dict.RemoveValue("onE"));
   EXPECT_TRUE(base::Value::Equals(&string_value, removed_value.get()));
   EXPECT_TRUE(test_dict.values().empty());
 }
 
 TEST(RegistryDictTest, SetAndGetKeys) {
   RegistryDict test_dict;
 
   base::FundamentalValue int_value(42);
   base::StringValue string_value("fortytwo");
 
   scoped_ptr<RegistryDict> subdict(new RegistryDict());
   subdict->SetValue("one", scoped_ptr<base::Value>(int_value.DeepCopy()));
   test_dict.SetKey("two", subdict.Pass());
-  EXPECT_EQ(1, test_dict.keys().size());
+  EXPECT_EQ(1u, test_dict.keys().size());
   RegistryDict* actual_subdict = test_dict.GetKey("two");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&int_value, actual_subdict->GetValue("one")));
 
   subdict.reset(new RegistryDict());
   subdict->SetValue("three", scoped_ptr<base::Value>(string_value.DeepCopy()));
   test_dict.SetKey("four", subdict.Pass());
-  EXPECT_EQ(2, test_dict.keys().size());
+  EXPECT_EQ(2u, test_dict.keys().size());
   actual_subdict = test_dict.GetKey("two");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&int_value, actual_subdict->GetValue("one")));
   actual_subdict = test_dict.GetKey("four");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&string_value,
                                   actual_subdict->GetValue("three")));
 
   test_dict.ClearKeys();
   EXPECT_FALSE(test_dict.GetKey("one"));
   EXPECT_FALSE(test_dict.GetKey("three"));
   EXPECT_TRUE(test_dict.keys().empty());
 }
 
 TEST(RegistryDictTest, CaseInsensitiveButPreservingKeyNames) {
   RegistryDict test_dict;
 
   base::FundamentalValue int_value(42);
 
   test_dict.SetKey("One", make_scoped_ptr(new RegistryDict()).Pass());
-  EXPECT_EQ(1, test_dict.keys().size());
+  EXPECT_EQ(1u, test_dict.keys().size());
   RegistryDict* actual_subdict = test_dict.GetKey("One");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(actual_subdict->values().empty());
 
   RegistryDict::KeyMap::const_iterator entry = test_dict.keys().begin();
   ASSERT_NE(entry, test_dict.keys().end());
   EXPECT_EQ("One", entry->first);
 
   scoped_ptr<RegistryDict> subdict(new RegistryDict());
   subdict->SetValue("two", scoped_ptr<base::Value>(int_value.DeepCopy()));
   test_dict.SetKey("ONE", subdict.Pass());
-  EXPECT_EQ(1, test_dict.keys().size());
+  EXPECT_EQ(1u, test_dict.keys().size());
   actual_subdict = test_dict.GetKey("One");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&int_value,
                                   actual_subdict->GetValue("two")));
 
   scoped_ptr<RegistryDict> removed_key(test_dict.RemoveKey("one"));
   ASSERT_TRUE(removed_key);
   EXPECT_TRUE(base::Value::Equals(&int_value,
                                   removed_key->GetValue("two")));
   EXPECT_TRUE(test_dict.keys().empty());
@@ skipping 140 matching lines @@
 
   EXPECT_TRUE(base::Value::Equals(&int_value, test_dict.GetValue("one")));
   RegistryDict* actual_subdict = test_dict.GetKey("one");
   ASSERT_TRUE(actual_subdict);
   EXPECT_TRUE(base::Value::Equals(&string_value,
                                   actual_subdict->GetValue("two")));
 }
 
 }  // namespace
 }  // namespace policy