clang/win: Let remaining chromium_code targets build with -Wextra.

chrome/installer/util/installer_state_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/installer_state.h"
 
 #include <windows.h>
 
 #include <fstream>
 
@@ skipping 525 matching lines @@
     installer_state.target_path().Append(L"1.2.3.6"),
     installer_state.target_path().AppendASCII(kOldVersion),
     installer_state.target_path().AppendASCII(kOldChromeExeVersion),
     installer_state.target_path().Append(L"2.1.1.0"),
     installer_state.target_path().AppendASCII(kChromeExeVersion),
     installer_state.target_path().AppendASCII(kNewVersion),
     installer_state.target_path().Append(L"3.9.1.1"),
   };
 
   // Create the version directories.
-  for (int i = 0; i < arraysize(version_dirs); i++) {
+  for (size_t i = 0; i < arraysize(version_dirs); i++) {
     base::CreateDirectory(version_dirs[i]);
     EXPECT_TRUE(base::PathExists(version_dirs[i]));
   }
 
   // Create exes with the appropriate version resource.
   // Use the current test exe as a baseline.
   base::FilePath exe_path;
   ASSERT_TRUE(PathService::Get(base::FILE_EXE, &exe_path));
 
   struct target_info {
     base::FilePath target_file;
     const Version& target_version;
   } targets[] = {
     { installer_state.target_path().Append(installer::kChromeOldExe),
       old_chrome_exe_version },
     { installer_state.target_path().Append(installer::kChromeExe),
       chrome_exe_version },
     { installer_state.target_path().Append(installer::kChromeNewExe),
       new_chrome_exe_version },
   };
-  for (int i = 0; i < arraysize(targets); ++i) {
+  for (size_t i = 0; i < arraysize(targets); ++i) {
     ASSERT_TRUE(upgrade_test::GenerateSpecificPEFileVersion(
         exe_path, targets[i].target_file, targets[i].target_version));
   }
 
   // Call GetExistingExeVersions, validate that picks up the
   // exe resources.
   std::set<std::string> expected_exe_versions;
   expected_exe_versions.insert(kOldChromeExeVersion);
   expected_exe_versions.insert(kChromeExeVersion);
   expected_exe_versions.insert(kNewChromeExeVersion);
@@ skipping 249 matching lines @@
   // Critical update newer than the new version.
   EXPECT_FALSE(
       installer_state.DetermineCriticalVersion(NULL, *pv_version_).IsValid());
   EXPECT_FALSE(
       installer_state.DetermineCriticalVersion(opv_version_, *pv_version_)
           .IsValid());
   EXPECT_FALSE(
       installer_state.DetermineCriticalVersion(pv_version_, *pv_version_)
           .IsValid());
 }