Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: include/codec/SkAndroidCodec.h

Issue 1513023002: Make BitmapRegionDecoder succeed on invalid requests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Default to the suggested color type instead of kN32 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/android/SkBitmapRegionCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/codec/SkAndroidCodec.h
diff --git a/include/codec/SkAndroidCodec.h b/include/codec/SkAndroidCodec.h
index f979886a43ec33c573de3553b49651a8a06d7025..64880076a37a44f7042157d65f77777043c247f9 100644
--- a/include/codec/SkAndroidCodec.h
+++ b/include/codec/SkAndroidCodec.h
@@ -53,6 +53,23 @@ public:
SkEncodedFormat getEncodedFormat() const { return this->onGetEncodedFormat(); }
/**
+ * @param requestedColorType Color type requested by the client
+ *
+ * @return If it is possible to decode to requestedColorType, this returns
+ * requestedColorType. Otherwise, this returns kN32_SkColorType.
+ */
+ SkColorType fixRequestedColorType(SkColorType requestedColorType);
djsollen 2015/12/10 21:06:45 this seems like an odd name to me. something like
msarett 2015/12/10 22:41:55 Changing to computeOutput*Type()
+
+ /**
+ * @param requestedUnpremul Indicates if the client requested
+ * unpremultiplied output
+ *
+ * @return Returns the appropriate alpha type to decode to. If the image
+ * has alpha, the value of requestedUnpremul will be honored.
+ */
+ SkAlphaType fixRequestedAlphaType(bool requestedUnpremul);
+
+ /**
* Returns the dimensions of the scaled output image, for an input
* sampleSize.
*
« no previous file with comments | « no previous file | src/android/SkBitmapRegionCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698