Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/android/SkBitmapRegionCanvas.h

Issue 1513023002: Make BitmapRegionDecoder succeed on invalid requests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/android/SkBitmapRegionCanvas.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/android/SkBitmapRegionCanvas.h
diff --git a/src/android/SkBitmapRegionCanvas.h b/src/android/SkBitmapRegionCanvas.h
index 2edbf1ff3bddd9d34eaf7f404a5fcc45afc79ba5..c01f96be3c4306c1112ed2a71adf9ef96bd72ff8 100644
--- a/src/android/SkBitmapRegionCanvas.h
+++ b/src/android/SkBitmapRegionCanvas.h
@@ -14,8 +14,16 @@
* an SkCanvas. It uses the scanline decoder to subset the height. It then
* will subset the width and scale by drawing to an SkCanvas.
*/
-// FIXME (msarett): This implementation does not support WEBP, because WEBP
-// does not have a scanline decoder.
+// FIXME: This class works well as a performance/quality comparison for
+// SkBitmapRegionCodec, but it lacks several capabilities that are
+// required by BitmapRegionDecoder in Android.
+// (1) WEBP decodes - because SkWebpCodec does not have a scanline
+// decoder.
+// (2) Decodes to kGray8 and kIndex8.
+// (3) Decodes to kUnpremul.
+// (4) Correcting an invalid dstColorType. For example, if the
+// client requests kRGB_565 for a non-opaque image, rather than
+// fail, we need to go ahead and decode to kN32.
class SkBitmapRegionCanvas : public SkBitmapRegionDecoder {
public:
« no previous file with comments | « include/codec/SkAndroidCodec.h ('k') | src/android/SkBitmapRegionCanvas.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698