Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: include/codec/SkAndroidCodec.h

Issue 1513023002: Make BitmapRegionDecoder succeed on invalid requests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/android/SkBitmapRegionCanvas.cpp » ('j') | src/android/SkBitmapRegionCanvas.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/codec/SkAndroidCodec.h
diff --git a/include/codec/SkAndroidCodec.h b/include/codec/SkAndroidCodec.h
index f979886a43ec33c573de3553b49651a8a06d7025..9e12afb3607240dfcb2c51fc25b680277e1379a6 100644
--- a/include/codec/SkAndroidCodec.h
+++ b/include/codec/SkAndroidCodec.h
@@ -42,6 +42,28 @@ public:
*/
static SkAndroidCodec* NewFromData(SkData*, SkPngChunkReader* = NULL);
+ /**
+ * @param requestedColorType Color type requested by the client
+ * @param suggestedColorType Color type suggested by SkAndroidCodec
+ * @param suggestedAlphaType Alpha type suggested by SkAndroidCodec
+ *
+ * @return If it is possible to decode to requestedColorType, this returns
+ * requestedColorType. Otherwise, this returns kN32_SkColorType.
+ */
+ static SkColorType FixRequestedColorType(SkColorType requestedColorType,
+ SkColorType suggestedColorType, SkAlphaType suggestedAlphaType);
+
+ /**
+ * @param requestedUnpremul Indicates if the client requested
+ * unpremultiplied output
+ * @param suggestedAlphaType Alpha type suggested by SkAndroidCodec
+ *
+ * @return Returns the appropriate alpha type to decode to. If the image
+ * has alpha, the value of requestedUnpremul will be honored.
+ */
+ static SkAlphaType FixRequestedAlphaType(bool requestedUnpremul,
+ SkAlphaType suggestedAlphaType);
+
virtual ~SkAndroidCodec() {}
« no previous file with comments | « no previous file | src/android/SkBitmapRegionCanvas.cpp » ('j') | src/android/SkBitmapRegionCanvas.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698