Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1512963002: PPC64: [turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: [turbofan] Change TruncateFloat64ToUint64 to TryTruncateFloatToUint64. Port c343f30923ab8b9f99d3f565e8ab65837cbb9efb Original commit message: This operator now provides a second output which indicates whether the conversion from float64 to uint64 was successful or not. The second output returns 0 if the conversion fails, or something else if the conversion succeeds. The second output can be ignored, which means that the operator can be used the same as the original operator. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/caea1bbda0ccb3b2432f30e70664b4625f129d74 Cr-Commit-Position: refs/heads/master@{#32728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-09 17:58:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512963002/1
5 years ago (2015-12-09 17:58:30 UTC) #3
john.yan
lgtm
5 years ago (2015-12-09 18:09:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 18:35:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512963002/1
5 years ago (2015-12-09 18:35:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 18:36:56 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 18:37:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caea1bbda0ccb3b2432f30e70664b4625f129d74
Cr-Commit-Position: refs/heads/master@{#32728}

Powered by Google App Engine
This is Rietveld 408576698