Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1512903005: Add Apple renderer strings to PowerVR detection (Closed)

Created:
5 years ago by jvanverth1
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Apple renderer strings to PowerVR detection BUG=skia:4148 Committed: https://skia.googlesource.com/skia/+/f10ecb71a9189b3551fdc01300b5c56ad76c6a71

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +19 lines, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
jvanverth1
I'm guessing on some of these.
5 years ago (2015-12-10 16:22:36 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1512903005/diff/1/src/gpu/gl/GrGLUtil.cpp File src/gpu/gl/GrGLUtil.cpp (right): https://codereview.chromium.org/1512903005/diff/1/src/gpu/gl/GrGLUtil.cpp#newcode265 src/gpu/gl/GrGLUtil.cpp:265: static const char kAppleA4Str[] = "Apple A4"; I ...
5 years ago (2015-12-10 16:45:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512903005/1
5 years ago (2015-12-10 16:51:53 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 17:06:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f10ecb71a9189b3551fdc01300b5c56ad76c6a71

Powered by Google App Engine
This is Rietveld 408576698