Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1512903002: [v8natives.js] updating comments to ES6 (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[v8natives.js] updating comments to ES6 BUG= Committed: https://crrev.com/40817d22428a66c4de194ac95cd1ebac111d9c84 Cr-Commit-Position: refs/heads/master@{#32746}

Patch Set 1 #

Patch Set 2 : not touch parseInt #

Patch Set 3 : even less parseInt code changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -38 lines) Patch
M src/conversions.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/js/v8natives.js View 1 2 22 chunks +34 lines, -35 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512903002/1
5 years ago (2015-12-09 13:13:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/12934) v8_linux_arm_rel on ...
5 years ago (2015-12-09 13:15:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512903002/40001
5 years ago (2015-12-10 09:18:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 09:38:57 UTC) #8
Camillo Bruni
PTAL mostly updating comments (and checking that the code is more or less in sync ...
5 years ago (2015-12-10 10:13:20 UTC) #10
Yang
On 2015/12/10 10:13:20, cbruni wrote: > PTAL > mostly updating comments (and checking that the ...
5 years ago (2015-12-10 10:18:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512903002/40001
5 years ago (2015-12-10 10:18:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 10:42:51 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-10 10:43:44 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40817d22428a66c4de194ac95cd1ebac111d9c84
Cr-Commit-Position: refs/heads/master@{#32746}

Powered by Google App Engine
This is Rietveld 408576698