test/cctest/test-deoptimization.cc - Issue 15129002: stop using AsciiValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-deoptimization.cc

Issue 15129002: stop using AsciiValue (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: adding deprecation notice Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-deoptimization.cc

diff --git a/test/cctest/test-deoptimization.cc b/test/cctest/test-deoptimization.cc

index 620f6fe1a776fecca30ce948412b23a521ce37e2..dfc27548b5ab47068987de21f4b2f8d6e1afe24f 100644

--- a/test/cctest/test-deoptimization.cc

+++ b/test/cctest/test-deoptimization.cc

@@ -376,8 +376,8 @@ TEST(DeoptimizeBinaryOperationADDString) {

CHECK_EQ(1, env->Global()->Get(v8_str("count"))->Int32Value());

v8::Handle<v8::Value> result = env->Global()->Get(v8_str("result"));

CHECK(result->IsString());

- v8::String::AsciiValue ascii(result);

- CHECK_EQ("a+an X", *ascii);

+ v8::String::Utf8Value utf8(result);

+ CHECK_EQ("a+an X", *utf8);

CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(Isolate::Current()));

}

« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »