Make skia_sanitizer work on Macs too.

Make skia_sanitizer work on Macs too.

This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/632199ec6e2b99beb87a2cb52969f00e61e5a138

[mtklein_C, 2015-12-09 19:12:46]

Description was changed from

==========
Make skia_sanitizer work on Macs too.

This is clearly limited by what the compiler suppports.  -fsanitize=address
seems OK.

BUG=skia:
==========

to

==========
Make skia_sanitizer work on Macs too.

This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.

BUG=skia:
==========

[mtklein_C, 2015-12-09 19:13:35]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com, herb@google.com

[herb_g, 2015-12-09 20:08:51]

lgtm

[mtklein, 2015-12-09 20:25:29]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-12-09 20:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512853005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512853005/1

[commit-bot: I haz the power, 2015-12-09 20:39:02]

Description was changed from

==========
Make skia_sanitizer work on Macs too.

This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.

BUG=skia:
==========

to

==========
Make skia_sanitizer work on Macs too.

This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/632199ec6e2b99beb87a2cb52969f00e61e5a138
==========

[commit-bot: I haz the power, 2015-12-09 20:39:03]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/632199ec6e2b99beb87a2cb52969f00e61e5a138

[Nico, 2016-05-13 17:06:02]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-13 17:06:02]

https://codereview.chromium.org/1512853005/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1512853005/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:515: # but not to libtool. OTHER_LDFLAGS is passed to
both.
...or you could check if _type is not static_library like e.g. here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

That seems like a less hacky approach :-)