Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1512833007: A class that's only used as a field type should be considered used (Closed)

Created:
5 years ago by skybrian
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

A class that's only used as a field type should be considered used BUG=https://github.com/dart-lang/sdk/issues/25184 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f0eb582d493cbe59b356139e2ce79a3f626cf92d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
5 years ago (2015-12-10 02:45:24 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-10 03:28:40 UTC) #3
skybrian
5 years ago (2015-12-10 21:52:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0eb582d493cbe59b356139e2ce79a3f626cf92d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698