Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4011)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 151283006: Mac OS X: Show the Translate icon on Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue-307352-translate-bubble-2
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index 51bd7d9473f1cf64f95956096a0ccc83f4e8bc33..1c77cbfe6f3420e68f8bfe0edd7017cc0621ee4a 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -443,6 +443,10 @@ class NotificationBridge
locationBarView_->SetStarred(isStarred ? true : false);
}
+- (void)setTranslateIconToggled:(BOOL)on {
+ locationBarView_->SetTranslateIconToggled(on ? true : false);
Nico 2014/02/05 06:07:18 No need for ` ? true : false` here either.
hajimehoshi 2014/02/05 11:08:03 Done.
+}
+
- (void)zoomChangedForActiveTab:(BOOL)canShowBubble {
locationBarView_->ZoomChangedForActiveTab(
canShowBubble && ![wrenchMenuController_ isMenuOpen]);
@@ -734,6 +738,10 @@ class NotificationBridge
return [self.view convertPoint:point toView:nil];
}
+- (NSPoint)translateBubblePoint {
+ return locationBarView_->GetTranslateBubblePoint();
+}
+
- (CGFloat)desiredHeightForCompression:(CGFloat)compressByHeight {
// With no toolbar, just ignore the compression.
if (!hasToolbar_)

Powered by Google App Engine
This is Rietveld 408576698