chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm - Issue 151283006: Mac OS X: Show the Translate icon on Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

Issue 151283006: Mac OS X: Show the Translate icon on Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue-307352-translate-bubble-2

Patch Set: Use kAnimateNone Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm ('k') | chrome/browser/ui/cocoa/translate/translate_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

index e3bbfd31670effb6b835bc02670a960fe3fea879..469a9f188d1391a358a04ad99ba319f82e2dba67 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

@@ -216,6 +216,13 @@ TEST_F(ToolbarControllerTest, BookmarkBubblePoint) {

EXPECT_TRUE(NSPointInRect(starPoint, barFrame));

}

+TEST_F(ToolbarControllerTest, TranslateBubblePoint) {

+ const NSPoint translatePoint = [bar_ translateBubblePoint];

+ const NSRect barFrame =

+ [[bar_ view] convertRect:[[bar_ view] bounds] toView:nil];

+ EXPECT_TRUE(NSPointInRect(translatePoint, barFrame));

TEST_F(ToolbarControllerTest, HoverButtonForEvent) {

base::scoped_nsobject<HitView> view(

[[HitView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);