chrome/browser/ui/cocoa/toolbar/toolbar_controller.h - Issue 151283006: Mac OS X: Show the Translate icon on Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

Issue 151283006: Mac OS X: Show the Translate icon on Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue-307352-translate-bubble-2

Patch Set: groby's review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/location_bar/translate_decoration.mm ('K') | « chrome/browser/ui/cocoa/location_bar/translate_decoration.mm ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('j') | chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

index b0238973d50aa363409863125d2194ce49c8995c..7469a6a2e1a8d7e030c7308df589aef3488f40a2 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

@@ -122,6 +122,9 @@ class NotificationBridge;

// Sets whether or not the current page in the frontmost tab is bookmarked.

- (void)setStarredState:(BOOL)isStarred;

+// Sets whether or not the current page is translated.

+- (void)setTranslateIconLit:(BOOL)on;

// Happens when the zoom for the active tab changes, the active tab switches, or

// a new tab or browser window is created. |canShowBubble| indicates if it is

// appropriate to show a zoom bubble for the change.

@@ -142,6 +145,9 @@ class NotificationBridge;

// associated window's coordinate system.

- (NSPoint)bookmarkBubblePoint;

+// Point on the translate icon fot the Translate bubble.

+- (NSPoint)translateBubblePoint;

// Returns the desired toolbar height for the given compression factor.

- (CGFloat)desiredHeightForCompression:(CGFloat)compressByHeight;